----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18386/#review35338 -----------------------------------------------------------
Ship it! src/linux/fs.hpp <https://reviews.apache.org/r/18386/#comment65798> Well I see how you stumbled upon this fix.. :) Does this mean you did a grep to ensure all of the Option usage doesn't use the reference after the Option is re-assigned? src/log/catchup.cpp <https://reviews.apache.org/r/18386/#comment65799> Ditto earlier review for _ as a suffix: "proposal_". src/log/catchup.cpp <https://reviews.apache.org/r/18386/#comment65800> Did this not compile as it was? Looks like it would be ok. src/sched/sched.cpp <https://reviews.apache.org/r/18386/#comment65801> Ditto _ as a suffix. - Ben Mahler On Feb. 22, 2014, 12:51 a.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18386/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2014, 12:51 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1008 > https://issues.apache.org/jira/browse/MESOS-1008 > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > src/linux/fs.hpp 1d86dd0d24c3daae957b5eec387638d1e8e6d7db > src/linux/fs.cpp e5f4f9a16becd4e5960d0cbb7f988736188b2426 > src/log/catchup.cpp bcad2782d85aeb473f75e56b2e2f2874b32302e8 > src/log/log.cpp 62dc9286285d5981aa5fc63e125d3c3f51d4f457 > src/sched/sched.cpp dcb3158d2acd93a107fda51b19e92899a092e628 > > Diff: https://reviews.apache.org/r/18386/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
