> On Feb. 25, 2014, 12:03 a.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp, line 5 > > <https://reviews.apache.org/r/18446/diff/1/?file=502894#file502894line5> > > > > if we're using google style, the gtest and gmock headers should be > > below <string>
I guess we never followed that style in the code base. We should either follow g-style or update our style guide :) In the interest of keeping this diff short, I will defer it for now. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18446/#review35344 ----------------------------------------------------------- On Feb. 24, 2014, 11:50 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18446/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2014, 11:50 p.m.) > > > Review request for mesos, Charlie Carson and Dominic Hamon. > > > Bugs: MESOS-1025 > https://issues.apache.org/jira/browse/MESOS-1025 > > > Repository: mesos-git > > > Description > ------- > > Fixed these as part of MESOS-1025. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp > a0e6af896b19305370a8d7a76e54a4362ef71c28 > 3rdparty/libprocess/3rdparty/stout/include/stout/stopwatch.hpp > 7b22cb62a0713d872b3eba3bdb19ce496885f5bb > 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp > 267b5f95958e51a003657cec6689a81f2b7763a7 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > e06115573aa481bd4f561139cae1f4c07f7f3cf5 > > Diff: https://reviews.apache.org/r/18446/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
