> On Feb. 25, 2014, 12:05 a.m., Dominic Hamon wrote: > > src/log/leveldb.cpp, line 24 > > <https://reviews.apache.org/r/18442/diff/1/?file=502912#file502912line24> > > > > should be above google/ and leveldb/ as a C system header.
Deferring this change per my comment in https://reviews.apache.org/r/18446. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18442/#review35346 ----------------------------------------------------------- On Feb. 24, 2014, 11:51 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18442/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2014, 11:51 p.m.) > > > Review request for mesos, Charlie Carson and Dominic Hamon. > > > Repository: mesos-git > > > Description > ------- > > Fixed these as part of MESOS-1025. > > > Diffs > ----- > > src/common/resources.cpp 756f933c5c85750b0f18c52f58f1be9673596696 > src/common/values.cpp ce26119f7707749ee9b6fbad74d486407619ee45 > src/java/jni/org_apache_mesos_Log.cpp > 36c636d155c1581eeb7734cdbc5b6fac4ca42440 > src/linux/cgroups.cpp baeb35d5001446348b379bfd59d5ef02bc55b67b > src/local/main.cpp da431b76cddd162d76033ce5db58fb0f0e72a34f > src/log/catchup.cpp bcad2782d85aeb473f75e56b2e2f2874b32302e8 > src/log/consensus.cpp 580db20a8667d263583244367d06783a1c02004f > src/log/coordinator.cpp 96ab1219b4a03735e488c96f7617f7d3c2697f39 > src/log/leveldb.hpp 1df41730513fc20d022c9c206447075d15975f82 > src/log/leveldb.cpp 4cc39d076351df931535d7a7c84e6c805e03ffcb > src/log/log.hpp 1f0b30ddf8709cf64db7989775c8b0e926af99b5 > src/log/log.cpp 62dc9286285d5981aa5fc63e125d3c3f51d4f457 > src/log/recover.cpp 1841f1ffabe96533476621840859bef99b4abb03 > src/log/replica.cpp 746d6c35c9255775ab6e70b0daf1dcecf63c16a0 > src/log/tool/read.hpp 74faec0abea1ad6586f6039748ffd587d1ef71ac > src/log/tool/read.cpp ab6068d273d826e11aa73010dd4196d3ab567bdc > src/log/tool/replica.hpp b4333488e278f014bec8b72ca7e11f5033ddcc4a > src/master/constants.cpp 8a48bbbe1d452919562b21f9b73680c42271a207 > src/master/main.cpp 723d534726175287b9ca3bffed894f77433183f4 > src/master/master.hpp 768dc3d165510d9e65e4b44075256b2805fde18c > src/master/master.cpp de40884f873656cf91566ef49736cb8dda1300d8 > src/slave/constants.cpp 1226485e10f9a3f9995d1789258e17c68cdc0680 > src/slave/containerizer/isolators/cgroups/cpushare.cpp > b4dbb99ea1cd06aaa6692bb50fc7ffdb49424845 > src/slave/containerizer/isolators/cgroups/mem.hpp > aabb4df9165bbfd2bb879c84d4d4088e28a1c5ee > src/slave/containerizer/isolators/cgroups/mem.cpp > 7118f89ac3bb74b001bdc7a67598393384995f3f > src/slave/main.cpp 8aba4ed5d2fa5b5731e137167f397dc194363821 > src/slave/slave.hpp d82d4e9547fc8c44f2210e1fafec766c381ab35c > src/tests/fault_tolerance_tests.cpp > b0711cfd035f82dd2a4089831bd0eaa7d900e29e > src/tests/log_tests.cpp 2613e414942fc6ff6e312fd8145567679e2545fb > src/tests/slave_recovery_tests.cpp 0fc256b51aae46d16b6c2abc10cc16a925f29246 > src/tests/sorter_tests.cpp 00933691ea0ef2803f4ebd3d9adb426a82c2f315 > > Diff: https://reviews.apache.org/r/18442/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
