----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18426/#review35646 -----------------------------------------------------------
Ship it! Ship It! - Dominic Hamon On Feb. 24, 2014, 8 a.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18426/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2014, 8 a.m.) > > > Review request for mesos. > > > Bugs: MESOS-1030 > https://issues.apache.org/jira/browse/MESOS-1030 > > > Repository: mesos-git > > > Description > ------- > > After fixing MESOS-1009 and MESOS-1029 you still get these errors: > > In file included from ../../src/java/jni/convert.cpp:32: > ../../src/jvm/jvm.hpp:473:18: error: 'va_start' has undefined behavior with > reference types [-Werror,-Wvarargs] > va_start(args, method); > ^ > /root/clang/build/Release/bin/../lib/clang/3.5/include/stdarg.h:33:52: note: > expanded from macro 'va_start' > #define va_start(ap, param) __builtin_va_start(ap, param) > ^ > ../../src/jvm/jvm.hpp:470:53: note: parameter of type 'const Jvm::Method &' > is declared here > T Jvm::invoke(const jobject receiver, const Method& method, ...) > ^ > ../../src/jvm/jvm.hpp:488:18: error: 'va_start' has undefined behavior with > reference types [-Werror,-Wvarargs] > va_start(args, method); > ^ > /root/clang/build/Release/bin/../lib/clang/3.5/include/stdarg.h:33:52: note: > expanded from macro 'va_start' > #define va_start(ap, param) __builtin_va_start(ap, param) > ^ > ../../src/jvm/jvm.hpp:485:35: note: parameter of type 'const Jvm::Method &' > is declared here > T Jvm::invokeStatic(const Method& method, ...) > ^ > > ./../src/messages/state.hpp:19:9: error: '__MESSAGE_STATE_HPP__' is used as a > header guard here, followed by #define > of a different macro [-Werror,-Wheader-guard] > #ifndef __MESSAGE_STATE_HPP__ > ^~~~~~~~~~~~~~~~~~~~~ > ../../src/messages/state.hpp:20:9: note: '__MESSAGES_STATE_HPP__' is defined > here; did you mean > '__MESSAGE_STATE_HPP__'? > #define __MESSAGES_STATE_HPP__ > ^~~~~~~~~~~~~~~~~~~~~~ > __MESSAGE_STATE_HPP__ > > > Diffs > ----- > > src/jvm/jvm.hpp b4dff78 > src/jvm/jvm.cpp 6eb3a34 > src/messages/state.hpp 6245499 > > Diff: https://reviews.apache.org/r/18426/diff/ > > > Testing > ------- > > "make check" OK on Mac, small problem may remain on Ubuntu, suspect unrelated > issue. C test framework OK on Mac, but not on Ubuntu: all tasks end up in > state 5. Suspect an unrelated issue here. Java test framework runs on both > platforms. > > > Thanks, > > Bernd Mathiske > >
