----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18295/#review35663 -----------------------------------------------------------
src/Makefile.am <https://reviews.apache.org/r/18295/#comment66290> kill ws. src/Makefile.am <https://reviews.apache.org/r/18295/#comment66291> kill ws src/common/attributes.cpp <https://reviews.apache.org/r/18295/#comment66292> new line. pull this after 3rd party includes. src/common/attributes.cpp <https://reviews.apache.org/r/18295/#comment66293> new line. src/common/attributes.cpp <https://reviews.apache.org/r/18295/#comment66298> kill this? src/common/attributes.cpp <https://reviews.apache.org/r/18295/#comment66294> new line. src/common/build.cpp <https://reviews.apache.org/r/18295/#comment66308> pull this after 3rd party includes. src/common/date_utils.hpp <https://reviews.apache.org/r/18295/#comment66304> s/date_utils/date/ ? src/common/date_utils.hpp <https://reviews.apache.org/r/18295/#comment66300> not yours. but can you kill the ws. src/common/date_utils.cpp <https://reviews.apache.org/r/18295/#comment66306> Why do we need to wrap them in a namespace instead of having static fields? src/common/protobuf_utils.cpp <https://reviews.apache.org/r/18295/#comment66307> this should come after 3rd party includes. src/common/resources.cpp <https://reviews.apache.org/r/18295/#comment66309> new line. src/common/resources.cpp <https://reviews.apache.org/r/18295/#comment66310> new line. src/common/resources.cpp <https://reviews.apache.org/r/18295/#comment66312> new line. src/common/resources.cpp <https://reviews.apache.org/r/18295/#comment66311> new line. src/common/resources.cpp <https://reviews.apache.org/r/18295/#comment66313> new line. src/common/resources.cpp <https://reviews.apache.org/r/18295/#comment66314> new line. src/common/resources.cpp <https://reviews.apache.org/r/18295/#comment66315> new line. src/common/resources.cpp <https://reviews.apache.org/r/18295/#comment66316> new line. src/common/type_utils.cpp <https://reviews.apache.org/r/18295/#comment66319> reorder. src/common/type_utils.cpp <https://reviews.apache.org/r/18295/#comment66318> kill new line. src/common/type_utils.cpp <https://reviews.apache.org/r/18295/#comment66320> new line. src/slave/cgroups_isolator.hpp <https://reviews.apache.org/r/18295/#comment66322> pull this after 3rd party includes. src/slave/cgroups_isolator.cpp <https://reviews.apache.org/r/18295/#comment66323> Once you rebase this file no longer exists. src/slave/flags.hpp <https://reviews.apache.org/r/18295/#comment66324> pull this after 3rd party includes. src/slave/gc.hpp <https://reviews.apache.org/r/18295/#comment66327> Add a comment here // Forward declarations. src/slave/gc.cpp <https://reviews.apache.org/r/18295/#comment66328> pull this after 3rd party includes. src/slave/isolator.hpp <https://reviews.apache.org/r/18295/#comment66329> Pull this comment up to "struct UUID". src/slave/isolator.cpp <https://reviews.apache.org/r/18295/#comment66330> this file doesn't exist after rebase. src/slave/main.cpp <https://reviews.apache.org/r/18295/#comment66331> new line. src/slave/main.cpp <https://reviews.apache.org/r/18295/#comment66332> new line. src/slave/main.cpp <https://reviews.apache.org/r/18295/#comment66333> new line. src/slave/monitor.hpp <https://reviews.apache.org/r/18295/#comment66334> kill the new line. src/slave/monitor.cpp <https://reviews.apache.org/r/18295/#comment66335> pull this after 3rd party includes. src/slave/monitor.cpp <https://reviews.apache.org/r/18295/#comment66336> Why this optimization? These includes seem too verbose. src/slave/paths.cpp <https://reviews.apache.org/r/18295/#comment66341> kill new line. src/slave/slave.hpp <https://reviews.apache.org/r/18295/#comment66342> Pull this comment up. src/slave/slave.cpp <https://reviews.apache.org/r/18295/#comment66344> pull this after 3rd party includes. src/slave/state.cpp <https://reviews.apache.org/r/18295/#comment66343> pull this after 3rd party includes. src/slave/status_update_manager.hpp <https://reviews.apache.org/r/18295/#comment66346> pull this comment up. src/slave/status_update_manager.cpp <https://reviews.apache.org/r/18295/#comment66347> pull this after 3rd party includes. - Vinod Kone On Feb. 20, 2014, 12:57 a.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18295/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2014, 12:57 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-1022 > https://issues.apache.org/jira/browse/MESOS-1022 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/executor.hpp 7bc8ecac3f13431e6f7dd45deb06fecf6e0f5d8a > include/mesos/resources.hpp 59f495cdb2a2d55a6c436767789ee579cd5c2f97 > include/mesos/scheduler.hpp 2e4707edb40ce0aa702e20c5ef860ea79a70ade0 > include/mesos/values.hpp 64c138ca6c23ec450e42e3eecf3276e6fc305644 > src/Makefile.am c30706846bca1fa3287291e39f46a23713ad1ba4 > src/common/attributes.hpp a08cf188a6d9c27386fd10440d8944f0d7b6fa08 > src/common/attributes.cpp 851c92a88804370313bf052c85f99d483fd67416 > src/common/build.hpp 115e9cc3ec1e28d4622c7884bcbac904b24b95dd > src/common/build.cpp eed08eda4a0db572992187347a2199054ade26d2 > src/common/date_utils.hpp 085c1ce685316b3b96b7564c3613bf775a485054 > src/common/date_utils.cpp 22c7dacb0f5a265fb595cf8cd0486530d8c28d5c > src/common/lock.cpp 11c8e8c50d806271c36c2ec20633acf06447c37f > src/common/protobuf_utils.hpp 0f653414bc1bb2b632ec8cd9c8bd7202a53d42e1 > src/common/protobuf_utils.cpp PRE-CREATION > src/common/resources.cpp 756f933c5c85750b0f18c52f58f1be9673596696 > src/common/thread.hpp 7e487241e419adb6a64109a949ee80a965771b25 > src/common/thread.cpp PRE-CREATION > src/common/type_utils.hpp b8fc573e86775708b6a142217823b2d9985ceda9 > src/common/type_utils.cpp PRE-CREATION > src/common/values.cpp ce26119f7707749ee9b6fbad74d486407619ee45 > src/master/master.cpp a4e1b1f7327f01eb16f14c3fa08fc7a62048d36c > src/slave/cgroups_isolator.hpp 1a66dc630f0857db48b7cfb316fbbb15518fcec2 > src/slave/cgroups_isolator.cpp ef7dd682e5462d0158d6ea6654246d77000e9778 > src/slave/constants.hpp d237383ff8d00f4731b689a2a1592fdd36f09a4d > src/slave/flags.hpp 827b2d0d6dc8fa279f3187a09e5dc6d4799d17cd > src/slave/gc.hpp 328aa315d8ebd7ea5d05b57626ea4dbfc2206270 > src/slave/gc.cpp 405350bf8f498d2e59e9e6b4c4c19b7bdaa974de > src/slave/http.cpp c4f598faf6807214608cc89a6d9cf665133f95f3 > src/slave/isolator.hpp 9634535d8c746597b4bb6e278587a1b9ca8f1608 > src/slave/isolator.cpp c9643cf9c5657bc142482a71fb161233bffb3b9f > src/slave/main.cpp 44020af30a76c8092f5b280f86a1f2865efe0233 > src/slave/monitor.hpp b677410e20eeafa7eac9acb4e687af7c8d53809f > src/slave/monitor.cpp bb3723e967b0723bc2b925019b6e9c4170dcc071 > src/slave/paths.hpp 70ee0f31ebb294011e5ec6b05ce3ad28b2c4bacc > src/slave/paths.cpp PRE-CREATION > src/slave/process_isolator.hpp bc52f33d8e83fe026be712c8b15e689eb23dd65c > src/slave/process_isolator.cpp 09cb9968c914a095b5737b70bf5044865fc3a2c4 > src/slave/slave.hpp 2ddadb411f8b2f91a4a5038664f424d4eadfbb87 > src/slave/slave.cpp 213df86084e51ab8407c6f2c2bd24ba718560faa > src/slave/state.hpp 78b20ffae1f2f629d851784302648e3bf5349321 > src/slave/state.cpp 6c382cd30602ede60b7d526acc272adc16285a93 > src/slave/status_update_manager.hpp > 06ea4659cdd24cb1b82f389f404566ba14a663fb > src/slave/status_update_manager.cpp > 03f5eafefd6ed748bfd4511d654c23c7b460db66 > src/tests/slave_recovery_tests.cpp 4779509f95f6a62c22241aff5fc12d4fc2e92084 > > Diff: https://reviews.apache.org/r/18295/diff/ > > > Testing > ------- > > No functional change. Ran clean build and make check. > > Timed build: > before change - 26m30s > after change - 19m33s > > diff stats: 44 files changed, 1067 insertions(+), 1074 deletions(-) > > > Thanks, > > Dominic Hamon > >
