----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18488/#review35717 -----------------------------------------------------------
Ship it! src/log/coordinator.cpp <https://reviews.apache.org/r/18488/#comment66424> Can we add a little more detail here? How about: Demote the coordinator if a write operation is discarded since we don't actually know the write was successful or not and we really need to "catchup" that position before we try and do another write (see MESOS-1038 for more details). - Benjamin Hindman On Feb. 25, 2014, 11:20 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18488/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2014, 11:20 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1038 > https://issues.apache.org/jira/browse/MESOS-1038 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/log/coordinator.cpp 52e8305468c1b588d77e4fcd7b6e1a75c765a01f > src/tests/log_tests.cpp 1e59b24e231936e459654a0be0ab7ad7e3974008 > > Diff: https://reviews.apache.org/r/18488/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
