-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16724/
-----------------------------------------------------------
(Updated Feb. 27, 2014, 2:32 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Rebased and updated in response to BenH's feedback.
Bugs: MESOS-767
https://issues.apache.org/jira/browse/MESOS-767
Repository: mesos-git
Description
-------
Added completed frameworks/tasks to slave re-registration.
Fixes MESOS-767.
Additional issues discovered during investigation:
- MESOS-905: Remove Framework.id in favor of FrameworkInfo.id
- MESOS-906: Last task in Completed Framework never graduates from
terminatedTasks to completedTasks.
- Completed frameworks/executors/tasks are stored in circular buffers,
and these may overflow in different orders on different slaves.
BenH proposes an archive to replace these circular buffers.
Diffs (updated)
-----
include/mesos/scheduler.hpp 55db177
src/master/master.hpp 72525d2
src/master/master.cpp 2e86a19
src/messages/messages.proto 922a8c4
src/slave/slave.cpp 4f5349b
src/tests/fault_tolerance_tests.cpp 59632b0
src/tests/mesos.hpp 018d4ff
Diff: https://reviews.apache.org/r/16724/diff/
Testing
-------
make check; manually failed-over a master, watched the slave reregister its
completed frameworks, web UI shows completed tasks and stdout/stderr.
Added a new unit/integration test to verify the expected behavior.
Thanks,
Adam B
