----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18445/#review36148 -----------------------------------------------------------
Looks like this is not sufficient for 'make check': ../../src/tests/log_tests.cpp: In member function ‘virtual void RecoverTest_RacingCatchup_Test::TestBody()’: ../../src/tests/log_tests.cpp:1539: error: passing ‘const process::Owned<mesos::internal::log::Replica>’ as ‘this’ argument of ‘process::Shared<T> process::Owned<T>::share() [with T = mesos::internal::log::Replica]’ discards qualifiers - Ben Mahler On March 4, 2014, 7:19 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18445/ > ----------------------------------------------------------- > > (Updated March 4, 2014, 7:19 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1008 > https://issues.apache.org/jira/browse/MESOS-1008 > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > src/log/log.cpp 62dc9286285d5981aa5fc63e125d3c3f51d4f457 > > Diff: https://reviews.apache.org/r/18445/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
