Thank you guys for the great comments! It's now committed. - Jie
On Tue, Mar 4, 2014 at 11:06 AM, Ben Mahler <[email protected]>wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18093/#review36142 > ----------------------------------------------------------- > > Ship it! > > > Ship It! > > - Ben Mahler > > > On March 4, 2014, 6:58 p.m., Jie Yu wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/18093/ > > ----------------------------------------------------------- > > > > (Updated March 4, 2014, 6:58 p.m.) > > > > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > > > > Bugs: MESOS-993 > > https://issues.apache.org/jira/browse/MESOS-993 > > > > > > Repository: mesos-git > > > > > > Description > > ------- > > > > See summary. > > > > > > Diffs > > ----- > > > > 3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a760 > > 3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp > PRE-CREATION > > 3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp > PRE-CREATION > > > > Diff: https://reviews.apache.org/r/18093/diff/ > > > > > > Testing > > ------- > > > > make check > > > > repeat 1000 times for the IntervalTest > > > > Repeating all tests (iteration 100) . . . > > > > Note: Google Test filter = *Interval* > > [==========] Running 7 tests from 1 test case. > > [----------] Global test environment set-up. > > [----------] 7 tests from IntervalTest > > [ RUN ] IntervalTest.Interval > > [ OK ] IntervalTest.Interval (0 ms) > > [ RUN ] IntervalTest.Addition > > [ OK ] IntervalTest.Addition (0 ms) > > [ RUN ] IntervalTest.Subtraction > > [ OK ] IntervalTest.Subtraction (0 ms) > > [ RUN ] IntervalTest.Intersection > > [ OK ] IntervalTest.Intersection (0 ms) > > [ RUN ] IntervalTest.LargeInterval > > [ OK ] IntervalTest.LargeInterval (0 ms) > > [ RUN ] IntervalTest.ElementIteration > > [ OK ] IntervalTest.ElementIteration (0 ms) > > [ RUN ] IntervalTest.IntervalIteration > > [ OK ] IntervalTest.IntervalIteration (0 ms) > > [----------] 7 tests from IntervalTest (0 ms total) > > > > [----------] Global test environment tear-down > > [==========] 7 tests from 1 test case ran. (0 ms total) > > [ PASSED ] 7 tests. > > > > > > Thanks, > > > > Jie Yu > > > > > >
