----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18753/#review36186 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp <https://reviews.apache.org/r/18753/#comment67102> Doesn't look like you need this? 3rdparty/libprocess/3rdparty/stout/include/stout/os/shell.hpp <https://reviews.apache.org/r/18753/#comment67103> You just need <ostream> for this. 3rdparty/libprocess/3rdparty/stout/include/stout/os/shell.hpp <https://reviews.apache.org/r/18753/#comment67104> Why isn't 'fmt' a const _reference_ or named something nicer, like 'format'. Feel free to punt since it's orthogonal to this change. - Ben Mahler On March 4, 2014, 11:13 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18753/ > ----------------------------------------------------------- > > (Updated March 4, 2014, 11:13 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am > d5c9c68a8c2488009ae8a4336ac910c7795be169 > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 20d028f98159f40ae4d1f02af21a2c5258258c4f > 3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp > f5bd1c9eb11e9ae9c9e13a72dc23239a0ff6acd6 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/shell.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/18753/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
