Dominic Hamon created MESOS-1055:
------------------------------------
Summary: Add explicit to single argument constructors
Key: MESOS-1055
URL: https://issues.apache.org/jira/browse/MESOS-1055
Project: Mesos
Issue Type: Improvement
Components: c++ api
Reporter: Dominic Hamon
Priority: Minor
>From the google style guide:
Normally, if a constructor takes one argument, it can be used as a conversion.
For instance, if you define Foo::Foo(string name) and then pass a string to a
function that expects a Foo, the constructor will be called to convert the
string into a Foo and will pass the Foo to your function for you. This can be
convenient but is also a source of trouble when things get converted and new
objects created without you meaning them to. Declaring a constructor explicit
prevents it from being invoked implicitly as a conversion.
Implicit conversions should be the exception to avoid unwanted and unexpected
behaviour.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
