----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18828/#review36375 -----------------------------------------------------------
Ship it! Ship It! - Vinod Kone On March 6, 2014, 2:27 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18828/ > ----------------------------------------------------------- > > (Updated March 6, 2014, 2:27 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-1058 > https://issues.apache.org/jira/browse/MESOS-1058 > > > Repository: mesos-git > > > Description > ------- > > See: MESOS-1058. > > The regression is quite clear when looking at: > > commit 7a38b74f021132fe79f1f4d0ac8940239880ea74 > Author: Benjamin Mahler <[email protected]> > Date: Tue Oct 1 13:51:16 2013 -0700 > > Fixed a bug with resource accounting in reconciliation. > > Review: https://reviews.apache.org/r/14435 > > > Diffs > ----- > > src/master/master.cpp f7ba9aafe7d476b59f5333458ca9a63b0dc622b9 > > Diff: https://reviews.apache.org/r/18828/diff/ > > > Testing > ------- > > Writing a test turned out to be prohibitive here for two reasons: > > 1. We cannot simulate a spurious exited event. > 2. Given 1, I restarted the slave in the test, however the new slave gets a > new PID, thereby not exercising the correct code in the Master. > > make check passes > > > Thanks, > > Ben Mahler > >
