> On March 6, 2014, 7:52 p.m., Benjamin Hindman wrote: > > src/tests/cluster.hpp, line 108 > > <https://reviews.apache.org/r/18370/diff/5/?file=507531#file507531line108> > > > > I'm late to this party, but why did we change this to be called > > MasterInfo? This clashes with another type we have called MasterInfo and > > upon a cursory look seems unnecessary. Moreover if we needed this change we > > didn't change the Slave struct below to be called SlaveInfo for consistency.
Charlie can you follow up on benh's comment by sending a new patch? You can resolve the above issue once you do so. Thanks. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18370/#review36415 ----------------------------------------------------------- On March 1, 2014, 1:15 a.m., Charlie Carson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18370/ > ----------------------------------------------------------- > > (Updated March 1, 2014, 1:15 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1024 > https://issues.apache.org/jira/browse/MESOS-1024 > > > Repository: mesos-git > > > Description > ------- > > Refactor Cluster::Master::start methods > > There are currently two overloads of the Cluster::Masters::start > function. One takes a argument of AllocatorProcess* and the other > does not. The AllocatorProcess* overload serves two purposes: > 1) it allows an alternative implementation of AllocatorProcess to be > passed (i.e. a mock) > 2) it changes the destruction timing so that the passed in argument > can outlive the master. > > Beyond that, the two functions are identical. This changes the > parameter to be Option<AllocatorProcess*> and allows all the logic > to be in one method. The old function exists for back-compat but > now simply forward by passing in None() to the other function. > > This is for two purposes: > 1) reduce code duplication > 2) position the code so that we can also optionally pass in a mock > repaier. > > Review: https://reviews.apache.org/r/18370 > > > Diffs > ----- > > src/tests/cluster.hpp d1bf680ed3f6a0fb16af85a21409d653d44522ca > > Diff: https://reviews.apache.org/r/18370/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Charlie Carson > >
