> On March 6, 2014, 9:57 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp, line 103 > > <https://reviews.apache.org/r/18863/diff/1/?file=512989#file512989line103> > > > > Should this be "<" instead of "<=" ? > > > > Also, can you attach the bug to the RB?
No, we can add 'argc' if it's equal to tokens.size() since tokens.size() + argc == tokens.end() in the case argc == tokens.size() which is valid. My guess is that we might be getting some cases where argc > tokens.size() and we're trying to increment the iterator beyond where it should go (and it blindly does that instead of realizing it's past tokens.end()). - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18863/#review36433 ----------------------------------------------------------- On March 6, 2014, 9:59 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18863/ > ----------------------------------------------------------- > > (Updated March 6, 2014, 9:59 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-963 > https://issues.apache.org/jira/browse/MESOS-963 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp > f5bd1c9eb11e9ae9c9e13a72dc23239a0ff6acd6 > > Diff: https://reviews.apache.org/r/18863/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
