----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18862/#review36432 -----------------------------------------------------------
Ship it! I added some cleanup notes in case you wanted to do any cleanup. Since you're just moving this function into a new file, I didn't mark any of these as issues. 3rdparty/libprocess/3rdparty/stout/include/stout/os/shell.hpp <https://reviews.apache.org/r/18862/#comment67371> Would be nice to clean up the variables names in this! 3rdparty/libprocess/3rdparty/stout/include/stout/os/shell.hpp <https://reviews.apache.org/r/18862/#comment67373> s/cmdline/command/ 3rdparty/libprocess/3rdparty/stout/include/stout/os/shell.hpp <https://reviews.apache.org/r/18862/#comment67380> 'popen' sometimes sets 'errno' if we want to use ErrnoError as a best effort. 3rdparty/libprocess/3rdparty/stout/include/stout/os/shell.hpp <https://reviews.apache.org/r/18862/#comment67376> s/ ;/;/ 3rdparty/libprocess/3rdparty/stout/include/stout/os/shell.hpp <https://reviews.apache.org/r/18862/#comment67377> Why is this using ErrnoErrror? 3rdparty/libprocess/3rdparty/stout/include/stout/os/shell.hpp <https://reviews.apache.org/r/18862/#comment67378> ErrnoError? - Ben Mahler On March 6, 2014, 9:47 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18862/ > ----------------------------------------------------------- > > (Updated March 6, 2014, 9:47 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am > b53a3f190fa834c97472fb6222ef3f5b0a4748f4 > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 20d028f98159f40ae4d1f02af21a2c5258258c4f > 3rdparty/libprocess/3rdparty/stout/include/stout/os/shell.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/18862/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
