----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18595/#review36486 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp <https://reviews.apache.org/r/18595/#comment67472> This seems a little strange, because we'll be trying to signal multiple times: root <- signaled 1 time child <- signaled 2 times grandchild <- signaled 3 times ... Nth level pid <- signaled N times Also, how will this be used? Let's say you use this for a 5 minute signal escalation on the tree originally returned by killtree(pid_t, int, bool, bool). 5 minutes later, how do you know the pids are still valid and you don't accidentally kill unrelated processes? - Ben Mahler On Feb. 28, 2014, 12:54 a.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18595/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2014, 12:54 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > New killtree(ProcessTree tree, int signal) traverse process tree and sends a > signal to all pids. This is done regardless of presence and state of process. > Patch is used by up coming signal escalation. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp 1f45897 > > Diff: https://reviews.apache.org/r/18595/diff/ > > > Testing > ------- > > Functional testing with signal escalation code and make check. > > > Thanks, > > Niklas Nielsen > >
