----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18945/#review36604 -----------------------------------------------------------
Ship it! src/master/main.cpp <https://reviews.apache.org/r/18945/#comment67651> This is already included above. - Benjamin Hindman On March 9, 2014, 5:29 p.m., Nikita Vetoshkin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18945/ > ----------------------------------------------------------- > > (Updated March 9, 2014, 5:29 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-1068 > https://issues.apache.org/jira/browse/MESOS-1068 > > > Repository: mesos-git > > > Description > ------- > > Subj. Looks like a bit copy-paste, please advise where to put this to be > shared between slave and master code. > I can see some useful defines like -DPACKAGE_STRING during build, but I don't > see if it's used somewhere. > > > Diffs > ----- > > src/master/flags.hpp 159b2de5878927613ba94f81005dba601f072026 > src/master/main.cpp 4c74a1b387dc99aa223cb9cf8a096d3b4a126a0a > src/slave/flags.hpp e4d98a53cbfb7f9ca828f17e82d492274cb9969d > src/slave/main.cpp a498a6ae6a79c7155c07a5d6dc2d6c9dc8ae060f > > Diff: https://reviews.apache.org/r/18945/diff/ > > > Testing > ------- > > make check passes, manually tested --version option on master and slave > > > Thanks, > > Nikita Vetoshkin > >
