----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18954/#review36659 -----------------------------------------------------------
3rdparty/libprocess/include/process/future.hpp <https://reviews.apache.org/r/18954/#comment67693> i know it doesn't match the include order, but it might be more maintainable as we move towards C++11 to put this as the #else stanza above. 3rdparty/libprocess/include/process/future.hpp <https://reviews.apache.org/r/18954/#comment67694> is the callback responsible for checking the future then? would it be better to avoid calling the callback if the future has been discarded to avoid boilerplate/mistakes? 3rdparty/libprocess/include/process/future.hpp <https://reviews.apache.org/r/18954/#comment67695> you could use lambda::function in both the C++11 and boost cases to make future cleanup easier. 3rdparty/libprocess/src/tests/process_tests.cpp <https://reviews.apache.org/r/18954/#comment67698> maybe this should be a separate test, to avoid having to do cleanup in between and accidentally introducing dependencies. - Dominic Hamon On March 10, 2014, 1:03 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18954/ > ----------------------------------------------------------- > > (Updated March 10, 2014, 1:03 a.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > This is to avoid a standard pattern seen with doing a 'delay' after some > asynchronous function call has been made and we're waiting on it's completion > via Future::then, onAny, etc. This allows one to do: > > someAsynchronousFunction() > .then(defer(self(), &Self::_continuation1)) > .then(defer(self(), &Self::_continuation2)) > .after(Seconds(30), defer(self(), &Self::_timeout, lambda::_1)); > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp > 27b0970bf1d1ae1b977ddfc2de5ee858f1031bf5 > 3rdparty/libprocess/include/process/http.hpp > 7f549ba3476ecf5dec0db21d57ee58bcd73d5996 > 3rdparty/libprocess/src/tests/process_tests.cpp > e899aed7dbe6e8645484fe0ba69521e9fb0fdad2 > > Diff: https://reviews.apache.org/r/18954/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
