> On March 10, 2014, 10:33 a.m., Vinod Kone wrote: > > configure.ac, line 628 > > <https://reviews.apache.org/r/18973/diff/1/?file=515205#file515205line628> > > > > How does this work when users disable "cxx11"? > > Dominic Hamon wrote: > The same way it did before - this flag enables GTEST to be more > intelligent about trying to use tuple/tr1::tuple. When C++11 is disabled, it > checks the libc version to determine what should be available. It's much more > sophisticated in this version. > > I will run tests under more compiler versions to make sure.
This fails to build under g++4.4 _with_ c++11. https://groups.google.com/d/topic/googlemock/XvPDUENM5JM/discussion So we need g++ 4.7 to use gmock 1.7 in c++11 which is a shame as it massively simplifies the tuple issue. Discarding this issue. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18973/#review36666 ----------------------------------------------------------- On March 10, 2014, 10:23 a.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18973/ > ----------------------------------------------------------- > > (Updated March 10, 2014, 10:23 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-1044 and MESOS-750 > https://issues.apache.org/jira/browse/MESOS-1044 > https://issues.apache.org/jira/browse/MESOS-750 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz > d45d9894b0214f5f02a88f6da5c258327110efd8 > 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION > 3rdparty/libprocess/3rdparty/versions.am > 97727537778511ca5a10be4f3c25cd21d9166669 > 3rdparty/libprocess/configure.ac 88aeaada170fbc846794e00047cd5aa9835f9fcf > LICENSE b45416f1cc1bb98e8edb1ebdc078b05e6c514439 > configure.ac 91ddf57b3836bcdb31e5f7cf1e64cf8d14743374 > > Diff: https://reviews.apache.org/r/18973/diff/ > > > Testing > ------- > > clean build make check > > > Thanks, > > Dominic Hamon > >
