----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18974/#review36669 -----------------------------------------------------------
src/slave/containerizer/mesos_containerizer.cpp <https://reviews.apache.org/r/18974/#comment67713> new line. src/slave/containerizer/mesos_containerizer.cpp <https://reviews.apache.org/r/18974/#comment67715> What about checking this for emptyness too? Actually, instead of checking for emptyness we should make these flags optional (as the TODO in slave/flags.hpp suggests) and just check isSome() here. Better to do this fix in a different review. src/slave/containerizer/mesos_containerizer.cpp <https://reviews.apache.org/r/18974/#comment67727> s/buildCommand/setenv/ ? src/tests/containerizer_tests.cpp <https://reviews.apache.org/r/18974/#comment67722> // Forward declaration. src/tests/containerizer_tests.cpp <https://reviews.apache.org/r/18974/#comment67723> s/std::/string/string/ src/tests/containerizer_tests.cpp <https://reviews.apache.org/r/18974/#comment67724> ditto. src/tests/containerizer_tests.cpp <https://reviews.apache.org/r/18974/#comment67725> ditto. src/tests/containerizer_tests.cpp <https://reviews.apache.org/r/18974/#comment67717> new line. src/tests/containerizer_tests.cpp <https://reviews.apache.org/r/18974/#comment67718> new line. src/tests/containerizer_tests.cpp <https://reviews.apache.org/r/18974/#comment67721> ws. src/tests/containerizer_tests.cpp <https://reviews.apache.org/r/18974/#comment67720> new line. src/tests/containerizer_tests.cpp <https://reviews.apache.org/r/18974/#comment67719> ws. - Vinod Kone On March 10, 2014, 5:41 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18974/ > ----------------------------------------------------------- > > (Updated March 10, 2014, 5:41 p.m.) > > > Review request for mesos, Ian Downes and Vinod Kone. > > > Bugs: MESOS-1050 and MESOS-1063 > https://issues.apache.org/jira/browse/MESOS-1050 > https://issues.apache.org/jira/browse/MESOS-1063 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > src/Makefile.am 384b3122b61294401ba4a894c06e985d9fc2fb1e > src/slave/containerizer/mesos_containerizer.cpp > 9bf9829fb38f17d9a2a0d3ab33d45d34cd5d3ea5 > src/tests/containerizer_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/18974/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
