-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19024/#review36768
-----------------------------------------------------------
Bad patch!
Reviews applied: [19024]
Failed command: make -j3 check GTEST_FILTER='' >/dev/null
Error:
ev.c:1531:31: warning: 'ev_default_loop_ptr' initialized and declared 'extern'
[enabled by default]
ev.c: In function 'evpipe_write':
ev.c:2160:17: warning: ignoring return value of 'write', declared with
attribute warn_unused_result [-Wunused-result]
ev.c:2172:17: warning: ignoring return value of 'write', declared with
attribute warn_unused_result [-Wunused-result]
ev.c: In function 'pipecb':
ev.c:2193:16: warning: ignoring return value of 'read', declared with attribute
warn_unused_result [-Wunused-result]
ev.c:2207:16: warning: ignoring return value of 'read', declared with attribute
warn_unused_result [-Wunused-result]
In file included from /usr/include/c++/4.6/ext/hash_set:61:0,
from src/glog/stl_logging.h:54,
from src/stl_logging_unittest.cc:34:
/usr/include/c++/4.6/backward/backward_warning.h:33:2: warning: #warning This
file includes at least one deprecated or antiquated header which may be removed
without further notice at a future date. Please use a non-deprecated interface
with equivalent functionality instead. For a listing of replacement headers and
interfaces, consult the file backward_warning.h. To disable this warning use
-Wno-deprecated. [-Wcpp]
In file included from src/utilities.h:73:0,
from src/googletest.h:38,
from src/stl_logging_unittest.cc:48:
src/base/mutex.h:137:0: warning: "_XOPEN_SOURCE" redefined [enabled by default]
/usr/include/features.h:166:0: note: this is the location of the previous
definition
warning: no files found matching 'Makefile' under directory 'docs'
warning: no files found matching 'indexsidebar.html' under directory 'docs'
In file included from slave/containerizer/cgroups_launcher.cpp:26:0:
./linux/cgroups.hpp:393:26: error: wrong number of template arguments (2,
should be 1)
../3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp:26:7: error:
provided for 'template<class T> class Try'
./linux/cgroups.hpp:396:5: error: expected identifier before string constant
./linux/cgroups.hpp:396:5: error: expected ',' or '...' before string constant
./linux/cgroups.hpp:396:16: error: invalid type in declaration before ';' token
./linux/cgroups.hpp:437:27: error: wrong number of template arguments (2,
should be 1)
../3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp:26:7: error:
provided for 'template<class T> class Try'
./linux/cgroups.hpp:440:5: error: expected identifier before string constant
./linux/cgroups.hpp:440:5: error: expected ',' or '...' before string constant
./linux/cgroups.hpp:440:19: error: invalid type in declaration before ';' token
./linux/cgroups.hpp:488:26: error: wrong number of template arguments (2,
should be 1)
../3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp:26:7: error:
provided for 'template<class T> class Try'
./linux/cgroups.hpp:491:5: error: expected identifier before string constant
./linux/cgroups.hpp:491:5: error: expected ',' or '...' before string constant
./linux/cgroups.hpp:491:20: error: invalid type in declaration before ';' token
make[2]: *** [slave/containerizer/libmesos_no_3rdparty_la-cgroups_launcher.lo]
Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [check] Error 2
make: *** [check-recursive] Error 1
- Mesos ReviewBot
On March 11, 2014, 9:37 a.m., Archana kumari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19024/
> -----------------------------------------------------------
>
> (Updated March 11, 2014, 9:37 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed a TODO // TODO(bmahler): Consider namespacing stat for
> each subsystem (e.g. // cgroups::memory::stat and cgroups::cpuacct::stat).in
> linux/cgroups.hpp
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp 65f0958
>
> Diff: https://reviews.apache.org/r/19024/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Archana kumari
>
>
