----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19068/#review36847 -----------------------------------------------------------
Patch looks great! Reviews applied: [19068] All tests passed. - Mesos ReviewBot On March 11, 2014, 9:38 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19068/ > ----------------------------------------------------------- > > (Updated March 11, 2014, 9:38 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas > Nielsen, and Vinod Kone. > > > Bugs: MESOS-1079 > https://issues.apache.org/jira/browse/MESOS-1079 > > > Repository: mesos-git > > > Description > ------- > > Workaround for incompatibility of clang 3.4 with build settings of Apple's > Python distribution. Adds PYTHON_CFLAGS and PYTHON_CPPFLAGS to configuration > phase. Those variables are pre-populated by the contents of CFLAGS and > CPPFLAGS. When clang is used for the compilation, the -Qunused-arguments > override is added to both variables to deescalate possible errors caused by > unknown commandline flags towards warnings, thus allowing to build our Python > egg with clang 3.4 (Xcode 5.1) and Apple's default Python. > > > Diffs > ----- > > configure.ac 390f11b > src/Makefile.am 384b312 > > Diff: https://reviews.apache.org/r/19068/diff/ > > > Testing > ------- > > make check (clang and gcc, osx and linux) > > > Thanks, > > Till Toenshoff > >
