-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19086/#review36899
-----------------------------------------------------------
Bad patch!
Reviews applied: [19086]
Failed command: make -j3 check GTEST_FILTER='' >/dev/null
Error:
ev.c:1531:31: warning: 'ev_default_loop_ptr' initialized and declared 'extern'
[enabled by default]
ev.c: In function 'evpipe_write':
ev.c:2160:17: warning: ignoring return value of 'write', declared with
attribute warn_unused_result [-Wunused-result]
ev.c:2172:17: warning: ignoring return value of 'write', declared with
attribute warn_unused_result [-Wunused-result]
ev.c: In function 'pipecb':
ev.c:2193:16: warning: ignoring return value of 'read', declared with attribute
warn_unused_result [-Wunused-result]
ev.c:2207:16: warning: ignoring return value of 'read', declared with attribute
warn_unused_result [-Wunused-result]
In file included from /usr/include/c++/4.6/ext/hash_set:61:0,
from src/glog/stl_logging.h:54,
from src/stl_logging_unittest.cc:34:
/usr/include/c++/4.6/backward/backward_warning.h:33:2: warning: #warning This
file includes at least one deprecated or antiquated header which may be removed
without further notice at a future date. Please use a non-deprecated interface
with equivalent functionality instead. For a listing of replacement headers and
interfaces, consult the file backward_warning.h. To disable this warning use
-Wno-deprecated. [-Wcpp]
In file included from src/utilities.h:73:0,
from src/googletest.h:38,
from src/stl_logging_unittest.cc:48:
src/base/mutex.h:137:0: warning: "_XOPEN_SOURCE" redefined [enabled by default]
/usr/include/features.h:166:0: note: this is the location of the previous
definition
src/tests/encoder_tests.cpp: In member function 'virtual void
Encoder_Response_Test::TestBody()':
src/tests/encoder_tests.cpp:26:28: error: invalid initialization of reference
of type 'const process::http::OK&' from expression of type 'const char*'
make[5]: *** [tests-encoder_tests.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [check-am] Error 2
make[3]: *** [check-recursive] Error 1
make[2]: *** [check-recursive] Error 1
make[1]: *** [check] Error 2
make: *** [check-recursive] Error 1
- Mesos ReviewBot
On March 12, 2014, 1:29 a.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19086/
> -----------------------------------------------------------
>
> (Updated March 12, 2014, 1:29 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Bugs: MESOS-1057
> https://issues.apache.org/jira/browse/MESOS-1057
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Applied either "explicit" or "/*implicit*/" to all single-arg constructors in
> lib process that do not take the constructed type as parameter.
>
> Sorted out which denotation to choose by compiling mess and fixing all the
> compile errors and by estimating whether implicit conversions might be
> intended by the original authors.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp d43f1b5
> 3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp 72dea4d
> 3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp ea5017f
> 3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp 12ba1ca
> 3rdparty/libprocess/3rdparty/stout/include/stout/exit.hpp aaccbb4
> 3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp d6b070f
> 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 0ce002c
> 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 3305d13
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp 88b5797
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp f32130a
> 3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp 201e4b8
> 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 6fe795f
> 3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp 3a10379
> 3rdparty/libprocess/3rdparty/stout/include/stout/set.hpp ea8a13f
> 3rdparty/libprocess/3rdparty/stout/include/stout/some.hpp 1a71ac4
> 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp d99b75a
> 3rdparty/libprocess/include/process/c++11/deferred.hpp 57a3df5
> 3rdparty/libprocess/include/process/deferred.hpp c18619e
> 3rdparty/libprocess/include/process/event.hpp ca407ec
> 3rdparty/libprocess/include/process/future.hpp 27b0970
> 3rdparty/libprocess/include/process/http.hpp 7f549ba
> 3rdparty/libprocess/include/process/owned.hpp 4a03ea4
> 3rdparty/libprocess/include/process/pid.hpp 5a77dbc
> 3rdparty/libprocess/include/process/process.hpp 37283ea
> 3rdparty/libprocess/include/process/shared.hpp 8f5b59b
> 3rdparty/libprocess/include/process/time.hpp bd31211
> 3rdparty/libprocess/include/process/timeout.hpp 4634b9f
> 3rdparty/libprocess/include/process/tuples/details.hpp 34a9fb5
> 3rdparty/libprocess/include/process/tuples/tuples.hpp 672ba6c
> 3rdparty/libprocess/src/decoder.hpp a34c005
> 3rdparty/libprocess/src/encoder.hpp 4810e99
> 3rdparty/libprocess/src/net.hpp 2fdc62a
> 3rdparty/libprocess/src/synchronized.hpp 7e0efe2
>
> Diff: https://reviews.apache.org/r/19086/diff/
>
>
> Testing
> -------
>
> No compile errors occur now and Mesos still seems to work. Compiled and ran
> simple test frameworks on MacOSX 10.9 with Clang 3.3 and on Ubuntu 13.10 with
> gcc4.7.1. Note: the former exercised the C++11 subdir in lib
> process/include/process/c++11, whereas the latter did not. So we have both
> variants of the affected file "deferred.hpp" covered.
>
>
> Thanks,
>
> Bernd Mathiske
>
>
