----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19117/#review37029 -----------------------------------------------------------
Patch looks great! Reviews applied: [19117] All tests passed. - Mesos ReviewBot On March 13, 2014, 3:34 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19117/ > ----------------------------------------------------------- > > (Updated March 13, 2014, 3:34 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-855 > https://issues.apache.org/jira/browse/MESOS-855 > > > Repository: mesos-git > > > Description > ------- > > Introduced a new environment variable, MESOS_NATIVE_JAVA_LIBRARY. That > variable still points towards libmesos. For allowing a smooth transition > away from MESOS_NATIVE_LIBRARY towards MESOS_NATIVE_JAVA_LIBRARY whithin > JVM based frameworks. > > Future versions of MESOS_NATIVE_LIBRARY will not point to valid JNI > bindings. > > A typical java-based framework relies on mesos.jar to do the loading > but may use some extra logic in its startup to make sure > MESOS_NATIVE[_JAVA]_LIBRARY is set/valid. That extra-logic should now > be adapted by the framework developers to use the new environment > variable instead of the old one. > MESOS_NATIVE_LIBRARY is now marked as being deprecated for use for JVM > based frameworks. > > Note: > MESOS_NATIVE_LIRBRAY will not be removed. It is kept for frameworks > that are not JVM based but need to bind to the self-contained Mesos > library. > > > Diffs > ----- > > bin/mesos-slave-flags.sh.in dc73aef > src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in 231d1e2 > src/slave/containerizer/containerizer.cpp d0a1023 > src/tests/environment.cpp 5c92fcd > > Diff: https://reviews.apache.org/r/19117/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
