-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19085/
-----------------------------------------------------------
(Updated March 14, 2014, 6:01 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Moved strict to be passed via Flags.
Depends on r/19135.
Bugs: MESOS-764
https://issues.apache.org/jira/browse/MESOS-764
Repository: mesos-git
Description
-------
This adds the notion of "non-strict" operations in the Registrar. Operations
that are not "strict" are always permitted.
This allows the state to be bootstrapped from the current cluster state and is
essential for those upgrading a running cluster from a pre-Registrar version of
Mesos.
I have included a TODO that discusses a simplified design of the Registrar per
a chat with benh. I'd like to implement this simplified design in a subsequent
change so I'd like to hear if there are any potential issues. The new design
would mean pushing Operations out to a header and allowing callers to use
Operations directly.
Diffs (updated)
-----
src/local/local.cpp e31c19c1bd0bc527275b818a8ce2bc1d54d8cb89
src/master/main.cpp a99fb6494f1dbbfce91698d5aaded2b982bbaab5
src/master/registrar.hpp 987a63b33bd26add3253f25f1471dd4a73471830
src/master/registrar.cpp d30172cee8525a80661135e6554bc0d78c7e314d
src/tests/cluster.hpp 24bb7508955599731f4a06eeffc15441afbe1721
src/tests/registrar_tests.cpp 95a6b53e479ea9131aca9b39f096e6dc9e6848f8
Diff: https://reviews.apache.org/r/19085/diff/
Testing
-------
make check
I've parameterized the existing tests for strict and non-strict operation.
I've also added a test to ensure that the state can be bootstrapped.
Thanks,
Ben Mahler
