----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19259/#review37433 -----------------------------------------------------------
3rdparty/libprocess/include/process/subprocess.hpp <https://reviews.apache.org/r/19259/#comment68960> It might be better to add a second method. The way this is written, anyone wanting to specify a child function will need to set the environment, which may not be useful. I propose a second method that takes a required function and an optional environment. 3rdparty/libprocess/include/process/subprocess.hpp <https://reviews.apache.org/r/19259/#comment68959> why the rename from environment? 3rdparty/libprocess/include/process/subprocess.hpp <https://reviews.apache.org/r/19259/#comment68962> Is there a reason this is restricted to void() methods only? 3rdparty/libprocess/src/subprocess.cpp <https://reviews.apache.org/r/19259/#comment68963> you have a 'using' - remove the lambda:: 3rdparty/libprocess/src/tests/subprocess_tests.cpp <https://reviews.apache.org/r/19259/#comment68964> only two indent when you add the braces. - Dominic Hamon On March 16, 2014, 4:05 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19259/ > ----------------------------------------------------------- > > (Updated March 16, 2014, 4:05 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Dominic Hamon, and > Ian Downes. > > > Bugs: MESOS-1102 > https://issues.apache.org/jira/browse/MESOS-1102 > > > Repository: mesos-git > > > Description > ------- > > Adds the ability to process::subprocess to run a function (lambda) within the > child context, after fork and before exec. > > NOTE: Such lambda must not contain any async unsafe code. For details on > async safety, see POSIX.1-2004 on async-signal-safe functions, also > referenced in the signal man-pages: > http://man7.org/linux/man-pages/man7/signal.7.html. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/subprocess.hpp > d16cbc1e3d464e1784f116ccdb327cf0784f07c2 > 3rdparty/libprocess/src/subprocess.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > d15d4d159105474117c4ea432b215431209ab539 > > Diff: https://reviews.apache.org/r/19259/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
