> On March 18, 2014, 6:58 p.m., Ian Downes wrote: > > src/slave/main.cpp, line 138 > > <https://reviews.apache.org/r/19263/diff/3/?file=522993#file522993line138> > > > > Why can't these additional checks be done in Containerizer::resources > > (in slave/containerizer/containerizer.cpp) and then you can return Error() > > according to these new checks?
just wanted to confirm if Error() would exit the code stating wrong mem or just output a warning. If it exits, then we could move the check part to containerizer.cpp. - ASHUTOSH ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19263/#review37601 ----------------------------------------------------------- On March 17, 2014, 5:21 p.m., ASHUTOSH JAIN wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19263/ > ----------------------------------------------------------- > > (Updated March 17, 2014, 5:21 p.m.) > > > Review request for mesos, Adam B, Adam Berry, and Ben Mahler. > > > Bugs: MESOS-969 > https://issues.apache.org/jira/browse/MESOS-969 > > > Repository: mesos-git > > > Description > ------- > > resources (mem) provided by user not being checked > > link to issue: https://issues.apache.org/jira/browse/MESOS-969 > > > Diffs > ----- > > src/slave/main.cpp 8c2b70c > > Diff: https://reviews.apache.org/r/19263/diff/ > > > Testing > ------- > > make check > > > Thanks, > > ASHUTOSH JAIN > >
