> On March 18, 2014, 7:11 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp, line 322 > > <https://reviews.apache.org/r/19361/diff/1/?file=526317#file526317line322> > > > > this may call out to 'ls' every time through the loop. This is going to > > be slower than necessary, but also the contents may change between > > iterations.
My understanding is that 'os::ls' won't be evaluated multiple times. See the following links: http://cplusplus.bordoon.com/boost_foreach_techniques.html http://www.artima.com/cppsource/foreach.html A temporary result from os::ls will be stored. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19361/#review37605 ----------------------------------------------------------- On March 18, 2014, 5:54 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19361/ > ----------------------------------------------------------- > > (Updated March 18, 2014, 5:54 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Use directory entries in /proc/<pid>/task/ to get threads for <pid>. > > Two tests added which create children with 0 and 2 additional threads. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp > 201e4b88e352baf4ce0549c6359c034a3e1d960d > 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp > bc7e24821ef0bf887f0879033b0bb8dab70dcc2e > > Diff: https://reviews.apache.org/r/19361/diff/ > > > Testing > ------- > > make check # Linux > > > Thanks, > > Ian Downes > >
