----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19374/#review37660 -----------------------------------------------------------
Ship it! src/master/master.cpp <https://reviews.apache.org/r/19374/#comment69291> s/leading/elected yet/? I think thats more clear and inline with the if check? - Vinod Kone On March 18, 2014, 10:18 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19374/ > ----------------------------------------------------------- > > (Updated March 18, 2014, 10:18 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-764 > https://issues.apache.org/jira/browse/MESOS-764 > > > Repository: mesos-git > > > Description > ------- > > We used to not be able to make this change because we relied on Messages in > order to detect leadership. > > Rather than filtering in individual message handlers, this moves the > filtering to apply to all incoming message events. > > I cannot think of a case currently where a non-leading Master should reply to > a Message, but this may change in the future. For now, being able to filter > all Messages is what we'd like and is simpler than considering each case > individually. > > I've linked in MESOS-764 because this is needed to filter in a similar manner > when elected, but not recovered. > > > Diffs > ----- > > src/master/master.hpp 0c7c5204c31087f12c4e98028f90c1b941eab7c7 > src/master/master.cpp 6da776699beb6f449e8160dcb6a125d94c1ab437 > > Diff: https://reviews.apache.org/r/19374/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
