----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19312/#review37673 -----------------------------------------------------------
This is indeed a better approach! Can you update the review summary to describe your change? The summary is ultimately what will go into the commit message. src/slave/containerizer/containerizer.cpp <https://reviews.apache.org/r/19312/#comment69302> How about: } else { Bytes total = mem_.get().total; if (total >= Gigabytes(2)) { mem = total - Gigabytes(1); // Leave 1GB free. } else { mem = Bytes(total.bytes() / 2); // Use 50% of the memory. } } - Ben Mahler On March 18, 2014, 5 a.m., ASHUTOSH JAIN wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19312/ > ----------------------------------------------------------- > > (Updated March 18, 2014, 5 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1105 > https://issues.apache.org/jira/browse/MESOS-1105 > > > Repository: mesos-git > > > Description > ------- > > using 50% as criteria for mem less than 2GB else leave 1GB for OS. > > > Diffs > ----- > > src/slave/containerizer/containerizer.cpp d0a1023 > > Diff: https://reviews.apache.org/r/19312/diff/ > > > Testing > ------- > > make check > > > Thanks, > > ASHUTOSH JAIN > >
