----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19164/#review37680 -----------------------------------------------------------
Looks good! src/slave/containerizer/mesos_containerizer.cpp <https://reviews.apache.org/r/19164/#comment69309> What if we just call this 'fetcherEnvironment' or something similar? 'Map' is encoded in the return type and the fact that we're building the map is also implied, no? src/slave/containerizer/mesos_containerizer.cpp <https://reviews.apache.org/r/19164/#comment69310> How about calling this 'environment'? src/slave/containerizer/mesos_containerizer.cpp <https://reviews.apache.org/r/19164/#comment69311> How about calling this 'environment'? - Ben Mahler On March 18, 2014, 10:59 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19164/ > ----------------------------------------------------------- > > (Updated March 18, 2014, 10:59 p.m.) > > > Review request for mesos, Ben Mahler and Ian Downes. > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > src/slave/containerizer/mesos_containerizer.cpp > c819c97d96d232a1de3c1ed2fc848bebf66981f7 > src/tests/containerizer_tests.cpp b539070e3f76bb878bd3aeb04da93f25bdcecbeb > > Diff: https://reviews.apache.org/r/19164/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Dominic Hamon > >
