----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19336/#review37764 -----------------------------------------------------------
configure.ac <https://reviews.apache.org/r/19336/#comment69464> Any reason not to nest this with the GCC stuff below? configure.ac <https://reviews.apache.org/r/19336/#comment69465> Can we wrap this at 80 characters please? configure.ac <https://reviews.apache.org/r/19336/#comment69466> This stuff is all really dense, for readability can we put a newline above here. configure.ac <https://reviews.apache.org/r/19336/#comment69477> Wrap at 80 characters please. configure.ac <https://reviews.apache.org/r/19336/#comment69467> Let's put a newline above this as well please. configure.ac <https://reviews.apache.org/r/19336/#comment69475> Can we easily print a warning message out? This seems a bit implicit for me, especially if someone explicitly set --with-cxx11. I suppose, however, that the same was true if someone explicitly set --without-cxx11 when using clang. Ideally if someone requests something we fail rather than ignore their request just to "make it work". - Benjamin Hindman On March 19, 2014, 7:10 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19336/ > ----------------------------------------------------------- > > (Updated March 19, 2014, 7:10 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-1095 and MESOS-1121 > https://issues.apache.org/jira/browse/MESOS-1095 > https://issues.apache.org/jira/browse/MESOS-1121 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > configure.ac 9a6de87fa6523bf8137f5d74ea0b7c6cbd947d3a > m4/ax_compare_version.m4 PRE-CREATION > > Diff: https://reviews.apache.org/r/19336/diff/ > > > Testing > ------- > > make check GTEST_FILTER='' > > clang, g++-4.4, g++-4.6, g++-4.7, g++-4.8; with and without c++11 > > > Thanks, > > Dominic Hamon > >
