> On March 19, 2014, 6:39 p.m., Ben Mahler wrote: > > src/master/master.hpp, line 732 > > <https://reviews.apache.org/r/19372/diff/5/?file=528686#file528686line732> > > > > Can you just forward declare these in the header? > > > > Otherwise I would be inclined to leave the implementation in the header > > given how small these are and how much easier it is to understand them. We > > already do this in Master for simple things like 'Slave' and 'Framework'. > >
I cannot forward declare because it's for regisrar_tests.cpp where the operation classes are instantiated. Put it back to the header. > On March 19, 2014, 6:39 p.m., Ben Mahler wrote: > > src/master/registrar.hpp, lines 62-64 > > <https://reviews.apache.org/r/19372/diff/5/?file=528688#file528688line62> > > > > This may prove useful with future operations, but the difference > > between an invalid operation and an operation that cannot be applied is a > > bit fuzzy. > > > > How about for now you add some sanity CHECKs for slave IDs in the > > constructors for the Master's operations, and we can think about validation > > in a later follow up? Fine, just wanted to put the code out there and we can reference it later. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19372/#review37850 ----------------------------------------------------------- On March 19, 2014, 5:12 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19372/ > ----------------------------------------------------------- > > (Updated March 19, 2014, 5:12 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1112 > https://issues.apache.org/jira/browse/MESOS-1112 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.hpp 0c7c5204c31087f12c4e98028f90c1b941eab7c7 > src/master/master.cpp 6da776699beb6f449e8160dcb6a125d94c1ab437 > src/master/registrar.hpp 98bfa1e83b7e6d28e011444a665155e31922446c > src/master/registrar.cpp cbb67bd17402692d3bb81fe58baea952897c56d1 > src/tests/registrar_tests.cpp 41836aeaf94e1b21e040b9e8ecf71e0b5a351f8e > > Diff: https://reviews.apache.org/r/19372/diff/ > > > Testing > ------- > > make check GTEST_FILTER=*Registrar* > > > Thanks, > > Jiang Yan Xu > >
