----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19416/#review37985 -----------------------------------------------------------
Just needs a header audit after the move, looks good otherwise! 3rdparty/libprocess/include/process/subprocess.hpp <https://reviews.apache.org/r/19416/#comment69856> Do you still need this in the header? 3rdparty/libprocess/include/process/subprocess.hpp <https://reviews.apache.org/r/19416/#comment69857> Move this to the .cpp for CHECK? 3rdparty/libprocess/include/process/subprocess.hpp <https://reviews.apache.org/r/19416/#comment69861> Move this to the .cpp? 3rdparty/libprocess/include/process/subprocess.hpp <https://reviews.apache.org/r/19416/#comment69858> Move this to the .cpp? 3rdparty/libprocess/include/process/subprocess.hpp <https://reviews.apache.org/r/19416/#comment69859> Move this to the .cpp? 3rdparty/libprocess/include/process/subprocess.hpp <https://reviews.apache.org/r/19416/#comment69860> Unused? 3rdparty/libprocess/src/subprocess.cpp <https://reviews.apache.org/r/19416/#comment69862> Looks like you need to include a few things here that we can't assume are coming from the header file: unistd.h // dup2, execl sys/types.h // pid_t abort.hpp error.hpp option.hpp future.hpp I'm not sure we should even bother with assuming the header has included anything as it requires some though, so let's just include <string> and try.hpp while we're at it. - Ben Mahler On March 19, 2014, 10:25 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19416/ > ----------------------------------------------------------- > > (Updated March 19, 2014, 10:25 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > see summary > > this is part zero of 19162 which will be rebased to depend on this. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 3c6219eb6e76306463b3710ab7e50ec8b75d3d76 > 3rdparty/libprocess/include/process/subprocess.hpp > 75b2a96b3ca62a4a59e64aba046f1d797bd8ebf6 > 3rdparty/libprocess/src/subprocess.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/19416/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
