----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19542/#review38178 -----------------------------------------------------------
Ship it! Would love to see an activate(Framework*) call that is the opposite of deactivate(Framework*) and we just always call activate when a framework (re-)registers, these could be no-ops when the framework is already in the corresponding state. Maybe let's leave a TODO for that? - Ben Mahler On March 21, 2014, 6:42 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19542/ > ----------------------------------------------------------- > > (Updated March 21, 2014, 6:42 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1135 > https://issues.apache.org/jira/browse/MESOS-1135 > > > Repository: mesos-git > > > Description > ------- > > See bug for details. > > > Diffs > ----- > > src/master/master.cpp 3b28f72be2016997e30649d2b12ed0e8f1a57dd5 > src/tests/fault_tolerance_tests.cpp > 3f4796a0f5ed236d20906ee90e2cf8d30b5e228b > src/tests/master_tests.cpp 42c5a77425209d96f8e7286102a672be50463a40 > > Diff: https://reviews.apache.org/r/19542/diff/ > > > Testing > ------- > > Updated 2 tests to verify the behavior. > > make check > > ./bin/mesos-tests.sh > --gtest_filter="*FaultToleranceTest.FrameworkReregister*:*MasterInfoOnReElection*" > --gtest_repeat=1000 --gtest_break_on_failure > > > Thanks, > > Vinod Kone > >
