> On March 18, 2014, 8:47 p.m., Adam B wrote: > > configure.ac, lines 584-595 > > <https://reviews.apache.org/r/18730/diff/5/?file=525834#file525834line584> > > > > How is this (and the many other new changes) related? Rebase needed? > > Separate/Dependent review? > > I think you're reverting Till's changes here. Unintentionally, I > > presume.
sorry. will rebase. > On March 18, 2014, 8:47 p.m., Adam B wrote: > > include/mesos/mesos.proto, lines 483-487 > > <https://reviews.apache.org/r/18730/diff/5/?file=525836#file525836line483> > > > > So, if permissive=false, nothing is allowed by default. Then if I > > specifically set an empty field/action (URL.PUT = {}), access is still > > denied, just more explicitly? > > What if I'm using a permissive=false authorization scheme and I want to > > grant global access to something (e.g. URL.GET.ips = [*])? > > > > Also, I think you mixed up your empty field/action examples. Shouldn't > > it be "an empty action (e.g. URL.PUT = {}) or field (e.g. URL.PUT.ips = > > [])." I've redone this because the previous iteration was admittedly untuitive. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18730/#review37627 ----------------------------------------------------------- On March 21, 2014, 11:44 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18730/ > ----------------------------------------------------------- > > (Updated March 21, 2014, 11:44 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen. > > > Bugs: MESOS-911 > https://issues.apache.org/jira/browse/MESOS-911 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto 37f8a7fcd23d467b1274c46c405b836510afbd49 > src/Makefile.am 0775a0df293e945d41c7ba90fd1bbb503ae22f9e > src/authorizer/authorizer.hpp PRE-CREATION > src/tests/authorization_tests.cpp PRE-CREATION > src/tests/master_contender_detector_tests.cpp > 8da7420e18c7a960b566fae13a5975857eb777ee > > Diff: https://reviews.apache.org/r/18730/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
