> On March 17, 2014, 12:58 p.m., Vinod Kone wrote: > > How about splitting the master tests as follows: > > > > Everything in master_tests except: > > > > ShutdownUnregisteredExecutor > > RemoveUnregisteredTerminatedExecutor > >
No problem with that. Will implement! - Bernd ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18752/#review37444 ----------------------------------------------------------- On March 10, 2014, 1:37 p.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18752/ > ----------------------------------------------------------- > > (Updated March 10, 2014, 1:37 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-610 > https://issues.apache.org/jira/browse/MESOS-610 > > > Repository: mesos-git > > > Description > ------- > > MESOS-610: Split slave specific tests out of master_tests. > > Not that most of the tests in master_test.cpp are very master-specific to > begin with. > Nor are any of them terribly slave-specific. > Typically, any such tests concern the whole Mesos conglomerate including the > scheduler driver. > The submitted patch suggests a more or less plausible split, > but other divisions are easily thinkable. > > I'd also be happy with keeping them all in one file and renaming that file, > maybe to "mesos_tests.cpp"? > > > Diffs > ----- > > src/Makefile.am 61d832b > src/tests/master_tests.cpp 42c5a77 > src/tests/slave_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/18752/diff/ > > > Testing > ------- > > Compiled and ran all tests ("make check") on Mac OS 10.9 / Clang 3.3 and > Ubuntu 13.10 / gcc 4.8.1. > > > Thanks, > > Bernd Mathiske > >
