> On March 26, 2014, 11:14 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [19672] > > > > Failed command: make -j3 check GTEST_FILTER='' >/dev/null > > > > Error: > > ev.c:1531:31: warning: 'ev_default_loop_ptr' initialized and declared > > 'extern' [enabled by default] > > ev.c: In function 'evpipe_write': > > ev.c:2160:17: warning: ignoring return value of 'write', declared with > > attribute warn_unused_result [-Wunused-result] > > ev.c:2172:17: warning: ignoring return value of 'write', declared with > > attribute warn_unused_result [-Wunused-result] > > ev.c: In function 'pipecb': > > ev.c:2193:16: warning: ignoring return value of 'read', declared with > > attribute warn_unused_result [-Wunused-result] > > ev.c:2207:16: warning: ignoring return value of 'read', declared with > > attribute warn_unused_result [-Wunused-result] > > In file included from /usr/include/c++/4.6/ext/hash_set:61:0, > > from src/glog/stl_logging.h:54, > > from src/stl_logging_unittest.cc:34: > > /usr/include/c++/4.6/backward/backward_warning.h:33:2: warning: #warning > > This file includes at least one deprecated or antiquated header which may > > be removed without further notice at a future date. Please use a > > non-deprecated interface with equivalent functionality instead. For a > > listing of replacement headers and interfaces, consult the file > > backward_warning.h. To disable this warning use -Wno-deprecated. [-Wcpp] > > In file included from src/utilities.h:73:0, > > from src/googletest.h:38, > > from src/stl_logging_unittest.cc:48: > > src/base/mutex.h:137:0: warning: "_XOPEN_SOURCE" redefined [enabled by > > default] > > /usr/include/features.h:166:0: note: this is the location of the previous > > definition > > warning: no files found matching 'Makefile' under directory 'docs' > > warning: no files found matching 'indexsidebar.html' under directory 'docs' > > zip_safe flag not set; analyzing archive contents... > > In file included from ./log/catchup.hpp:32:0, > > from log/catchup.cpp:31: > > ./log/network.hpp: In member function 'void ZooKeeperNetwork::watched(const > > process::Future<std::set<zookeeper::Group::Membership> >&)': > > ./log/network.hpp:414:61: error: no matching function for call to > > 'collect(std::list<process::Future<std::basic_string<char> > >&, > > process::Timeout)' > > ./log/network.hpp:414:61: note: candidate is: > > ../3rdparty/libprocess/include/process/collect.hpp:181:30: note: > > template<class T> process::Future<std::list<T> > process::collect(const > > std::list<process::Future<T> >&) > > make[2]: *** [log/liblog_la-catchup.lo] Error 1 > > make[2]: *** Waiting for unfinished jobs.... > > make[1]: *** [check] Error 2 > > make: *** [check-recursive] Error 1 > >
Updated review 19672 with this dependent. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19672/#review38590 ----------------------------------------------------------- On March 26, 2014, 7:31 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19672/ > ----------------------------------------------------------- > > (Updated March 26, 2014, 7:31 a.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/collect.hpp > 54b563f25213dc8406ecb4a23bbe5463336ee312 > > Diff: https://reviews.apache.org/r/19672/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
