> On March 26, 2014, 9:27 a.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/deferred.hpp, line 48 > > <https://reviews.apache.org/r/19086/diff/4/?file=537620#file537620line48> > > > > /*implicit*/ Deferred(const std::tr1::function<F>& f) > > : std::tr1::function<F>(f) {}
That's a matter of opinion. - Bernd ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19086/#review38616 ----------------------------------------------------------- On March 26, 2014, 8:55 a.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19086/ > ----------------------------------------------------------- > > (Updated March 26, 2014, 8:55 a.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Bugs: MESOS-1057 > https://issues.apache.org/jira/browse/MESOS-1057 > > > Repository: mesos-git > > > Description > ------- > > Applied either "explicit" or "/*implicit*/" to all single-arg constructors in > lib process that do not take the constructed type as parameter. > > Sorted out which denotation to choose by compiling mess and fixing all the > compile errors and by estimating whether implicit conversions might be > intended by the original authors. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/c++11/deferred.hpp 57a3df5 > 3rdparty/libprocess/include/process/deferred.hpp c18619e > 3rdparty/libprocess/include/process/event.hpp ca407ec > 3rdparty/libprocess/include/process/future.hpp 0be4af0 > 3rdparty/libprocess/include/process/http.hpp 15bd8a1 > 3rdparty/libprocess/include/process/owned.hpp 4a03ea4 > 3rdparty/libprocess/include/process/pid.hpp 5a77dbc > 3rdparty/libprocess/include/process/process.hpp 37283ea > 3rdparty/libprocess/include/process/shared.hpp 8f5b59b > 3rdparty/libprocess/include/process/time.hpp bd31211 > 3rdparty/libprocess/include/process/timeout.hpp 4634b9f > 3rdparty/libprocess/include/process/tuples/details.hpp 34a9fb5 > 3rdparty/libprocess/include/process/tuples/tuples.hpp 672ba6c > 3rdparty/libprocess/src/decoder.hpp a34c005 > 3rdparty/libprocess/src/encoder.hpp 4810e99 > 3rdparty/libprocess/src/httpd.cpp bbd5251 > 3rdparty/libprocess/src/net.hpp 2fdc62a > 3rdparty/libprocess/src/process.cpp 6c6acc0 > 3rdparty/libprocess/src/synchronized.hpp 7e0efe2 > 3rdparty/libprocess/src/test-slave.cpp fe08ce8 > 3rdparty/libprocess/src/tests/encoder_tests.cpp fccb865 > 3rdparty/libprocess/src/tests/process_tests.cpp be9099c > > Diff: https://reviews.apache.org/r/19086/diff/ > > > Testing > ------- > > No compile errors occur now and Mesos still seems to work. Compiled and ran > simple test frameworks on MacOSX 10.9 with Clang 3.3 and on Ubuntu 13.10 with > gcc4.7.1. Note: the former exercised the C++11 subdir in lib > process/include/process/c++11, whereas the latter did not. So we have both > variants of the affected file "deferred.hpp" covered. > > > File Attachments > ---------------- > > stout patch > > https://reviews.apache.org/media/uploaded/files/2014/03/26/f2d28d10-2345-42fa-a483-460e0781026e__MESOS-1057-stout.patch > > > Thanks, > > Bernd Mathiske > >
