----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19060/#review38741 -----------------------------------------------------------
Ship it! Good stuff! I'll get this committed today. Meanwhile, we should fix the new style errors found in a subsequent review :) src/master/detector.cpp:117: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp:46: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp:47: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp:50: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp:51: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp:310: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/gate.hpp:50: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/gate.hpp:73: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/net.hpp:84: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/net.hpp:86: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/net.hpp:88: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/net.hpp:90: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/net.hpp:103: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/net.hpp:105: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/net.hpp:107: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/net.hpp:109: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/net.hpp:120: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/net.hpp:123: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/net.hpp:125: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/net.hpp:127: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/net.hpp:129: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/net.hpp:140: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/net.hpp:142: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/net.hpp:144: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/net.hpp:146: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/net.hpp:156: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/net.hpp:157: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/net.hpp:158: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/net.hpp:178: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/net.hpp:179: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/net.hpp:182: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/net.hpp:184: Tab found; better to use spaces [whitespace/tab] [1] - Niklas Nielsen On March 25, 2014, 5:03 p.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19060/ > ----------------------------------------------------------- > > (Updated March 25, 2014, 5:03 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Bugs: MESOS-1080 > https://issues.apache.org/jira/browse/MESOS-1080 > > > Repository: mesos-git > > > Description > ------- > > Updated cpplint.py from > https://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py and > added hpp files as valid extensions. > > > Diffs > ----- > > support/cpplint.patch PRE-CREATION > support/cpplint.py a8c9f67 > > Diff: https://reviews.apache.org/r/19060/diff/ > > > Testing > ------- > > Ran cpplint.py with all rules enabled on some of my recent changes; found > style errors in hpp headers. > Ran mesos-style.py on all of mesos source. Found tabs in some > libprocess/stout headers. > > > Thanks, > > Adam B > >
