Hey List and Vinod, as the following commits are mandatory for getting things compiled properly on clang 3.4 (OSX, Xcode 5.1) and not just 3.5, I would like to have them included in the next RC.
162a7f5d84b3cc04e5f3a612e62bf76f1c1c25a4 Fixed compile errors in mesos with Clang 3.5 on Ubuntu 13.10. Review: https://reviews.apache.org/r/18426 66155da331d54710121e92db45358ea91aaac15d Fixed compile errors in lib stout when using Clang 3.5 on Ubuntu 13.10. Review: https://reviews.apache.org/r/18425 Without having them included, several warnings pop up (mostly variadic function related) which then get escalated to errors (due to -Werror). Example: In file included from ../../src/local/local.cpp:25: In file included from ../../3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp:20: In file included from ../../3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp:23: ../../3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp:402:18: error: 'va_start' has undefined behavior with reference types [-Werror,-Wvarargs] va_start(args, fmt); But also super helpful stuff like: ../../src/messages/state.hpp:19:9: error: '__MESSAGE_STATE_HPP__' is used as a header guard here, followed by #define of a different macro [-Werror,-Wheader-guard] #ifndef __MESSAGE_STATE_HPP__ ^~~~~~~~~~~~~~~~~~~~~ ../../src/messages/state.hpp:20:9: note: '__MESSAGES_STATE_HPP__' is defined here; did you mean '__MESSAGE_STATE_HPP__'? #define __MESSAGES_STATE_HPP__ ^~~~~~~~~~~~~~~~~~~~~~ __MESSAGE_STATE_HPP__ 2 errors generated. Got to love clang for that! :) cheers, Till On Mar 26, 2014, at 2:29 AM, Vinod Kone <vinodk...@gmail.com> wrote: > Hi folks, > > I just tagged 0.18.0-rc5 with some fixes that people have reported after > testing 0.18.0-rc4. > > Can you help us out by testing this rc? This will likely be voted upon as the > official 0.18.0 release in a few days unless some major issues crop up. > > Thanks, > -- Vinod
