> On March 27, 2014, 11:21 a.m., Vinod Kone wrote: > > RB doesn't show tab/space only changes i guess. This is how it looks in my > > "git show". > > > > commit 8ed4ae181474f5cae49d178dc50df3e938cc06fe > > Author: Vinod Kone <[email protected]> > > Date: Thu Mar 27 10:55:50 2014 -0700 > > > > Fixed tabs in mesos. > > > > Review: https://reviews.apache.org/r/19740 > > > > diff --git a/src/master/detector.cpp b/src/master/detector.cpp > > index ef9f1f5..2de1fd4 100644 > > --- a/src/master/detector.cpp > > +++ b/src/master/detector.cpp > > @@ -114,7 +114,7 @@ Try<MasterDetector*> MasterDetector::create(const > > string& master) > > } > > if (url.get().path == "/") { > > return Error( > > - "Expecting a (chroot) path for ZooKeeper ('/' is not supported)"); > > + "Expecting a (chroot) path for ZooKeeper ('/' is not > > supported)"); > > } > > return new ZooKeeperMasterDetector(url.get()); > > } else if (master.find("file://") == 0) { > >
confirmed from downloaded diff. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19740/#review38776 ----------------------------------------------------------- On March 27, 2014, 11:19 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19740/ > ----------------------------------------------------------- > > (Updated March 27, 2014, 11:19 a.m.) > > > Review request for mesos, Adam Berry and Dominic Hamon. > > > Repository: mesos-git > > > Description > ------- > > Caught some tabs with the latest fix to mesos-style.py > > > Diffs > ----- > > src/master/detector.cpp ef9f1f5fd97c4b86127e47211a08b3a0db651318 > > Diff: https://reviews.apache.org/r/19740/diff/ > > > Testing > ------- > > ? mesos git:(vinod/tab_fix) ? ./support/mesos-style.py > Checking 403 files... > Total errors found: 0 > > > Thanks, > > Vinod Kone > >
