----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18600/#review38826 -----------------------------------------------------------
Hey Jie, this looks really good. The only thing I would like to see before shipping is a test of the following: -Ensure that no-one transitions out of STARTING until all replicas are out of EMPTY. You could probably fit this into your existing test by delaying the creation of the 3rd replica? src/log/log.hpp <https://reviews.apache.org/r/18600/#comment71155> Can you update the documentation? I'm a bit hesitant about having an implicit 'auto-initialize=false', since it's less usable (from a developer/operator perspective). Maybe we should default to 'true' or require it to be specified? Up to you if you want to preserve the old API. src/log/recover.cpp <https://reviews.apache.org/r/18600/#comment71158> Great comments! s/then/them/ src/log/recover.cpp <https://reviews.apache.org/r/18600/#comment71159> Just for sanity: (2 * quorum) - 1 src/log/recover.cpp <https://reviews.apache.org/r/18600/#comment71160> Would you mind re-ordering to add EMPTY + STARTING just so that it matches your comments above? Ditto below for STARTING + VOTING. src/log/recover.cpp <https://reviews.apache.org/r/18600/#comment71161> Maybe we should make the transition to VOTING more explicit in the comment here? "If auto-initialization is enabled, all replicas will first go into STARTING status. Once *all* replicas have transitioned out of EMPTY status, the replicas will go into VOTING status." src/log/recover.cpp <https://reviews.apache.org/r/18600/#comment71162> "re-running"? - Ben Mahler On March 17, 2014, 11:30 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18600/ > ----------------------------------------------------------- > > (Updated March 17, 2014, 11:30 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-984 > https://issues.apache.org/jira/browse/MESOS-984 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/log/log.hpp c2cb6cf > src/log/log.cpp d9b2687 > src/log/recover.hpp 634bc06 > src/log/recover.cpp 688da5f > src/tests/log_tests.cpp b368cde > > Diff: https://reviews.apache.org/r/18600/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
