> On March 26, 2014, 10:15 p.m., Adam B wrote: > > src/master/drf_sorter.hpp, line 41 > > <https://reviews.apache.org/r/19090/diff/1/?file=517047#file517047line41> > > > > # of times since when? Since master/framework was (re)started? Or > > would/could this get recovered on master failover? This gets reset on > > framework restart/failover. > > Would we prefer a rolling window of "# of times client has been chosen > > for allocation in the last X minutes"?
I've updated the comment to explain the field in more detail, thanks for your comment! > On March 26, 2014, 10:15 p.m., Adam B wrote: > > src/master/drf_sorter.cpp, line 80 > > <https://reviews.apache.org/r/19090/diff/1/?file=517048#file517048line80> > > > > Do we really want to reset allocations on framework > > deactivate/reactivate? Would we rather save the allocations value and > > revive it on reactivate? > > Otherwise, a network disconnect or framework restart/failover will > > allow a framework to reset its allocations and move to the top of the list > > (but only if shares are already equal). Not a big deal. Ideally we don't reset the allocations, but the way the code currently works that's what we do. I've added a comment to address this in the future. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19090/#review37343 ----------------------------------------------------------- On March 12, 2014, 5:04 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19090/ > ----------------------------------------------------------- > > (Updated March 12, 2014, 5:04 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1086 > https://issues.apache.org/jira/browse/MESOS-1086 > > > Repository: mesos-git > > > Description > ------- > > See bug for more description. > > > Diffs > ----- > > src/master/drf_sorter.hpp f3fab71424fa10f87c87b733cc678fd90579a814 > src/master/drf_sorter.cpp bbf8270603e26a1b63e0f96bd5aa9c4ee4eb6d25 > > Diff: https://reviews.apache.org/r/19090/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
