----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19809/#review38967 -----------------------------------------------------------
Ship it! src/master/master.hpp <https://reviews.apache.org/r/19809/#comment71347> Let's move it back down for now and address the "slow tests" problem for all the tests at once. src/master/master.cpp <https://reviews.apache.org/r/19809/#comment71346> & ? src/tests/fault_tolerance_tests.cpp <https://reviews.apache.org/r/19809/#comment71344> Let's fix the "slowness due to retries" problem for all the tests in one swoop rather than for this specific test. src/tests/fault_tolerance_tests.cpp <https://reviews.apache.org/r/19809/#comment71343> Why the dynamic casts instead of what we do in, say, MasterTest.MasterInfoOnReElection? - Ben Mahler On March 28, 2014, 11:15 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19809/ > ----------------------------------------------------------- > > (Updated March 28, 2014, 11:15 p.m.) > > > Review request for mesos, Adam Berry, Benjamin Hindman, and Ben Mahler. > > > Bugs: MESOS-1161 > https://issues.apache.org/jira/browse/MESOS-1161 > > > Repository: mesos-git > > > Description > ------- > > See bug for details. > > > Diffs > ----- > > src/master/master.hpp eb8cd73e9e8f26a7438070ca2bb078bd2d1ec480 > src/master/master.cpp 5d0ddb0a567b1282bf164a5f1abc41a719208269 > src/tests/fault_tolerance_tests.cpp > 68280113ca32c4c4e0f335bed11044ba4184c34e > > Diff: https://reviews.apache.org/r/19809/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
