----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19006/#review38999 -----------------------------------------------------------
Patch looks great! Reviews applied: [19006] All tests passed. - Mesos ReviewBot On March 27, 2014, 4:41 a.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19006/ > ----------------------------------------------------------- > > (Updated March 27, 2014, 4:41 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-804 > https://issues.apache.org/jira/browse/MESOS-804 > > > Repository: mesos-git > > > Description > ------- > > Moved code to disconnect a checkpointing slave out of Master::exited() and > into a new disconnect(Slave), to be re-used by slave authentication code. > Also renamed deactivateSlave() to shutdownSlave(), since it actually sends a > ShutdownMessage and calls removeSlave(). This avoids confusion with > deactivateFramework, which is more analagous to disconnect(Slave). > > > Diffs > ----- > > src/master/master.hpp b6b9983 > src/master/master.cpp 5d0ddb0 > > Diff: https://reviews.apache.org/r/19006/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Adam B > >
