> On March 31, 2014, 7:46 p.m., Benjamin Hindman wrote: > > configure.ac, line 34 > > <https://reviews.apache.org/r/19854/diff/1/?file=542452#file542452line34> > > > > Can you explain why removing -Werror is necessary in a comment? Also, > > this seems dangerous ...
Warnings exist because the external builds do not have the 'subdir-objects' option enabled by default. They are only warnings and as we progress further on MESOS-1071, this will become less of an issue. >From an automake perspective, it's not dangerous. > On March 31, 2014, 7:46 p.m., Benjamin Hindman wrote: > > src/Makefile.am, lines 169-172 > > <https://reviews.apache.org/r/19854/diff/1/?file=542453#file542453line169> > > > > Why are these changes necessary? B/c the 'subdir-objects' option is specified and it's path is relative for both slave and master the collide. The two options that exist are: 1. Change the name 2. Breakout into sub-Makefile.am(s) - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19854/#review39095 ----------------------------------------------------------- On March 31, 2014, 6:16 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19854/ > ----------------------------------------------------------- > > (Updated March 31, 2014, 6:16 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-577 > https://issues.apache.org/jira/browse/MESOS-577 > > > Repository: mesos-git > > > Description > ------- > > Enable automake 1.14 > > > Diffs > ----- > > 3rdparty/libprocess/configure.ac 2e0b72c223955a21573c0d2937420635c128b4d8 > bootstrap ed0bc36b18855f3e317dc6c059b7277fd7ac041b > configure.ac 5404dc29a53368332b386a410226652ff7425fc7 > src/Makefile.am 47d03b393f68ebd4e9eba3206798a939078023c0 > src/master/constants.cpp > src/master/http.cpp > > Diff: https://reviews.apache.org/r/19854/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy St. Clair > >
