> On March 31, 2014, 8:03 p.m., Vinod Kone wrote: > > include/mesos/mesos.proto, line 498 > > <https://reviews.apache.org/r/17567/diff/15/?file=531795#file531795line498> > > > > Just convert the Termination struct in Containerizer to a protobuf and > > use it here. > > > > Maybe do split that into its own review first?
Yes, good idea. Proposed https://reviews.apache.org/r/19901/ but did not yet adapt this RR towards it. > On March 31, 2014, 8:03 p.m., Vinod Kone wrote: > > src/slave/containerizer/external_containerizer.cpp, lines 661-681 > > <https://reviews.apache.org/r/17567/diff/15/?file=531801#file531801line661> > > > > Is this from the posix isolator? If yes, can we refactor the code so > > that we can reuse. Maybe in its own review? 672 - 681 are indeed from the posix isolator. I am a bit unsure if refactoring those two case decisions with the setters would be an improvement. Would you please have a second look? - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/#review38504 ----------------------------------------------------------- On April 2, 2014, 2:02 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17567/ > ----------------------------------------------------------- > > (Updated April 2, 2014, 2:02 a.m.) > > > Review request for mesos, Ian Downes, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-816 > https://issues.apache.org/jira/browse/MESOS-816 > > > Repository: mesos-git > > > Description > ------- > > This patch adds the so-called external containerizer. This > containerizer delegates all containerizer calls directly to > an external containerizer program (which can be specified on > start-up). Few calls have internal fall-back implementations > such as wait(), destroy() and usage(). > > The protocol for the interactions with the external program > is as follows: > > COMMAND (ADDITIONAL-PARAMETERS) < INPUT-PROTO > RESULT-PROTO > > launch (ContainerID, --mesos-executor, <path>) < TaskInfo > ExternalStatus > update (ContainerID) < ResourceArray > ExternalStatus > usage (ContainerID) > ResourceStatistics > wait (ContainerID) > ExternalTermination > destroy (ContainerID) > ExternalStatus > > When protocol buffers need to be provided, the Mesos side of > the external containerizer implementation will serialize the > protos on stdin and vice-versa for reading protos on stdout as > drafted in the above scheme. > > > NOTE: This is currently work in progress to cover all comments. > > > Diffs > ----- > > configure.ac 5404dc2 > include/mesos/mesos.proto 37f8a7f > src/Makefile.am 0775a0d > src/examples/python/test-containerizer.in PRE-CREATION > src/examples/python/test_containerizer.py PRE-CREATION > src/slave/containerizer/containerizer.cpp 6de091e > src/slave/containerizer/external_containerizer.hpp PRE-CREATION > src/slave/containerizer/external_containerizer.cpp PRE-CREATION > src/slave/flags.hpp c9a627b > src/tests/external_containerizer_test.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/17567/diff/ > > > Testing > ------- > > make check and functional testing. > > > Thanks, > > Till Toenshoff > >
