> On March 31, 2014, 6:23 p.m., Adam B wrote: > > 3rdparty/libprocess/src/subprocess.cpp, lines 102-104 > > <https://reviews.apache.org/r/19162/diff/9/?file=530839#file530839line102> > > > > This only deletes the strings for the child environment and leaves the > > parent env strings alone, right? Is this intentional? Please fix or comment.
This is intentional - The parent env strings are pointers to the global environment so not owned by this code. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19162/#review39120 ----------------------------------------------------------- On March 26, 2014, 11:54 a.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19162/ > ----------------------------------------------------------- > > (Updated March 26, 2014, 11:54 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-995 > https://issues.apache.org/jira/browse/MESOS-995 > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > 3rdparty/libprocess/include/process/subprocess.hpp > 75b2a96b3ca62a4a59e64aba046f1d797bd8ebf6 > 3rdparty/libprocess/src/subprocess.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > d15d4d159105474117c4ea432b215431209ab539 > > Diff: https://reviews.apache.org/r/19162/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
