> On April 2, 2014, 5:35 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 123 > > <https://reviews.apache.org/r/19948/diff/1/?file=545964#file545964line123> > > > > this isn't necessarily malformed: > > > > MY_FILTER='--gtest_filter=Metric*' > > > >
Of course, thanks! I'll update the code and add a test. > On April 2, 2014, 5:35 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp, line 297 > > <https://reviews.apache.org/r/19948/diff/1/?file=545965#file545965line297> > > > > needed for this review? I added 'using std::vector' so it's just housekeeping. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19948/#review39301 ----------------------------------------------------------- On April 2, 2014, 5:32 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19948/ > ----------------------------------------------------------- > > (Updated April 2, 2014, 5:32 p.m.) > > > Review request for mesos, Dominic Hamon and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 901e5550c82c12934a6b9c3154f030c677e41a38 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 1babc1892dff0026c5d12178616a7a8457858eaa > > Diff: https://reviews.apache.org/r/19948/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
